silverstripe / silverstripe-cms

Silverstripe CMS - this is a module for Silverstripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up.
http://silverstripe.org/
BSD 3-Clause "New" or "Revised" License
516 stars 332 forks source link

API Deprecate and update code in preparation for CMS 6 #3023

Closed GuySartorelli closed 1 week ago

GuySartorelli commented 2 weeks ago

Needs https://github.com/silverstripe/silverstripe-framework/pull/11461 for CI to go green - please merge that PR first.

This PR deprecates code that will be removed in https://github.com/silverstripe/silverstripe-cms/pull/3022, and adds the new class_description config.

Note that there are a lot of methods in https://github.com/silverstripe/silverstripe-cms/pull/3022 which are being removed from SiteTree but are being added to a superclass or to the Hierarchy extension in https://github.com/silverstripe/silverstripe-framework/pull/11460. The Hierarchy extension is required to be on SiteTree for that class and CMSMain to work correctly, so the effect is that the methods are not removed from a downstream developer POV. Downstream developers can still override the methods in subclasses and call parent::whatever() as though the method was directly implemented on SiteTree.

Issue