search

silverstripe / silverstripe-cms

Silverstripe CMS - this is a module for Silverstripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up.
http://silverstripe.org/
BSD 3-Clause "New" or "Revised" License
515 stars 332 forks source link

OEmbed is not parsed in SS 3.1.0-beta2 #680

Closed manuelteuber closed 11 years ago

manuelteuber commented 11 years ago

When importing a youtube video via "add from internet" to the content of a page, the thumbnail shows up in the backend, but the [embed ...] code is displayed in the frontend (using the default theme "simple").

I think it is a SS 3.1 regression bug, because it works at demo.silverstripe.org, which is SS 3.0.

chillu commented 11 years ago

663

manuelteuber commented 11 years ago

In your screencast, you tried it with SilverStripe 3.0. As I mentioned, this features works in 3.0, but seems to be broken in 3.1 beta 2.

My screencast: http://www.screencast.com/t/3BdBo3ECDZN

Thank you.

samthejarvis commented 11 years ago

Can confirm this happens on a vanilla SS3.1 installation. Example output: http://samjarv.is/journal/play-character-in-title-chrome.

chillu commented 11 years ago

Can you reproduce with 3.1 branch? In general, don't file bugs for versions without checking the latest codebase. Composer is a good way to stay updated there: http://doc.silverstripe.org/framework/en/trunk/installation/composer

reflektera commented 11 years ago

I finally installed composer and with 3.1.x-dev for both CMS and Framework I also got this embed-problem.

chillu commented 11 years ago

@reflektera What URL are you trying to insert? Which browser? Could you make a screencast please? E.g. with www.techsmith.com/jing.html

And can you verify that you're actually running 3.1.x-dev by hovering over the silverstripe logo in the top left of the cms?

reflektera commented 11 years ago

@chillu. It's a Vimeo video (http://vimeo.com/64637903). The browser is Chrome, Version 26.0.1410.43. The screencast is from my local dev server, but same result online.

http://screencast.com/t/QFKIKOyu0Y

chillu commented 11 years ago

See https://github.com/silverstripe/sapphire/pull/1804