search

silverstripe / silverstripe-comments

Adds commenting functionality for Pages and other DataObjects on your Silverstripe site.
http://www.silverstripe.org/comments-module/
BSD 3-Clause "New" or "Revised" License
41 stars 80 forks source link

Tests report that getDate cannot be called on RSSFeed #252

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

Context: CWP 2.0.0, SilverStripe 4.1.1

This unit test fails:

1) SilverStripe\Comments\Tests\CommentingControllerTest::testRSS
BadMethodCallException: Object->__call(): the method 'getDate' does not exist on 'SilverStripe\Comments\Model\Comment'
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/Core/CustomMethods.php:54
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/Core/CustomMethods.php:79
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/View/ViewableData.php:131
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/View/ViewableData.php:483
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/View/ViewableData.php:528
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/View/SSViewer_Scope.php:323
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/View/SSViewer_DataPresenter.php:309
/tmp/silverstripe-cache-php7.0.25-home-travis-build-creative-commoners-cwp-recipe-kitchen-sink/travis/.cachevendor.silverstripe.framework.templates.SilverStripe.Control.RSS.RSSFeed.ss:48
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/View/SSViewer.php:602
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/View/SSViewer.php:674
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/View/ViewableData.php:397
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/framework/src/Control/RSS/RSSFeed.php:242
/home/travis/build/creative-commoners/cwp-recipe-kitchen-sink/vendor/silverstripe/comments/src/Controllers/CommentingController.php:233

Validated to be a false positive in practice.

robbieaverill commented 6 years ago

Resolved