User in Group field does not receive a notification email

silverstripe / silverstripe-contentreview

Mark a page in Silverstripe CMS with a date and an owner for future review

http://www.silverstripe.org/content-review-module/

BSD 3-Clause "New" or "Revised" License

22 stars 36 forks source link

User in Group field does not receive a notification email #125

Closed emteknetnz closed 2 years ago

emteknetnz commented 4 years ago

4.x-dev b6a6b59

Added the default "Content Author" to the Site settings > Content Review > Group field

I had a user belonging to the "Content Author" group

Change a page content review date to in the past and published

The user did not receive any notification
I tried to manually create the queued job "Content Review Notification Job". When I tried to manually run it had the status "Broken"

Acceptance criteria

[ ] When I assigned a user as a content reviewer, they will receive a notification email when content expire.
[ ] When I assigned a group as content reviewer, all members of that group will receive a notification email when content expire.
[ ] All content reviewers can interact with the content review modal whether they are directly define as a content review or added to a content reviewer group.
[ ] No errors should be thrown if the member is missing an email or if there's no member in a group added as a reviewer group.

brynwhyman commented 4 years ago

It might be worth double checking the email of the user within the Content Author group. See: #129

maxime-rainville commented 3 years ago

This is still present in CWP 2.7. My user wasn't getting the email when it mas a member of the review group. When I explicitly made it a reviewer, than I started getting email notifications.

emteknetnz commented 3 years ago

Still present in CWP 2.8.0-rc1

brynwhyman commented 3 years ago

Bumping this to impact/critical. As I understand the featureset of this module, users rely on notifications to know if content is ready for review.

GuySartorelli commented 2 years ago

@maxime-rainville @emteknetnz I can't reproduce this. Tested with Framework 4.10.4, CMS 4.10.1, contentreview 4.4.0

Are there specific modules I should be including in my install to check this? (e.g. you both mentioned CWP above)

emteknetnz commented 2 years ago

Yeah quite possibly it's specific to CWP. This issue was reported while doing manual regressing testing on CCL hosting (used for CWP) with the CWP "recipe-kitchen-sink" installed, so included the CWP mail configuration.

GuySartorelli commented 2 years ago

Still can't reproduce this. I have tried it in SCPS with both a 4.x and a 4.10.0 install of kitchen sink - in both cases I received an email triggered for a user in a reviewer group. I don't think this is a problem anymore, but it would be good for one of you two to confirm just in case there's something I've missed.

emteknetnz commented 2 years ago

If you can't replicate after following the replication steps, happy to close. This issue is still in our manual regression suite so we can reopen if required