search

silverstripe / silverstripe-dms

Adds a Document Management System to Silverstripe
BSD 3-Clause "New" or "Revised" License
40 stars 52 forks source link

fix page history: remove DMSSiteTreeExtension.getDocumentSets() #206

Closed xini closed 6 years ago

xini commented 6 years ago

DMSSiteTreeExtension.getDocumentSets() messes with the readonly mode in the page history, resulting in a 500 error.

robbieaverill commented 6 years ago

Hmmm... This breaks semver. Personally I'm OK with that, but it should be a minor release rather than a patch release at least. What do you think @NightJar?

xini commented 6 years ago

@robbieaverill any updates on this? cheers

xini commented 6 years ago

I have re-added the method and deprecated it so that we do a patch release for this.

NightJar commented 6 years ago

Nice work, thanks for this!

NightJar commented 6 years ago

Oh shoot, forgot to retarget before merging.

NightJar commented 6 years ago

Neat, I've merged your PR up into master @xini, and opened a PR to revert the 2.1 branch. Just to let you know your changes aren't being lost, but also that you should update any requirements to reference 2.2 as I'm about to tag it for you :)

https://github.com/silverstripe/silverstripe-dms/releases/tag/2.2.0

xini commented 6 years ago

awesome, thanks!