FIX: Ensure Version gridfield has correct field formatting and variables

silverstripe / silverstripe-dms

Adds a Document Management System to Silverstripe

BSD 3-Clause "New" or "Revised" License

40 stars 52 forks source link

FIX: Ensure Version gridfield has correct field formatting and variables #216

Closed Leapfrognz closed 6 years ago

Leapfrognz commented 6 years ago

With DMSDocument versioning enabled, the getCMSFields Versions Action Panel will generate errors because the string being passed for the field formatting fails when it is eval()'d

Leapfrognz commented 6 years ago

@robbieaverill yes. It was breaking the eval() in GridFieldDataColumns::formatValue() for me

dhensby commented 6 years ago

I've noticed that you've created this pull request from one of the "core branches" rather than a branch specifically intended for this pull request. This can cause problems if we ask you to target this PR at a different branch. No action is needed at the moment, this is for your information.

In the future please create a new branch for each individual pull request. See our guide about contributing PRs