search

silverstripe / silverstripe-dms

Adds a Document Management System to Silverstripe
BSD 3-Clause "New" or "Revised" License
40 stars 52 forks source link

fix front end sorting of documents #51

Closed xini closed 9 years ago

xini commented 10 years ago

fixes #44 for 1.0 branch. could possibly be merged into master as well. unfortunately I am unable to test this at the moment.

ss23 commented 10 years ago

These failing tests look like they're a legitimate issue. Are you able to look into them and fix them?

xini commented 10 years ago

interesting. makes sense. This is not a fix. but why is it working when installed? hm.. The basic problem is that the Documents method (https://github.com/silverstripe-labs/silverstripe-dms/blob/master/code/extensions/DMSSiteTreeExtension.php#L124) is not called from the template. the overloading in the extension doesn't work. any idea how to fix that?

xini commented 10 years ago

I have changed the commit. I have tried different things but IMHO the only solution is to use a different method name for the frontend instead of overloading Documents() (which never gets called).

xini commented 9 years ago

bump. thanks!

xini commented 9 years ago

That was quick! ;) Thanks!

ss23 commented 9 years ago

Yeah, I get that a lot... if you know what I mean... :(