search

silverstripe / silverstripe-elemental-fileblock

A file block for the dnadesign/silverstripe-elemental module
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

NEW Update singular and plural names #15

Closed emteknetnz closed 4 years ago

emteknetnz commented 4 years ago

Tweak for https://github.com/silverstripeltd/product-issues/issues/222

robbieaverill commented 4 years ago

I can't see the issue you referenced, but this is an enhancement as it was originally designed this way. Please target a minor release branch.

Edit: just noting that while the source translation is changing, I think it's less likely to affect non-English languages because it is adding more context to the existing noun (fine this way, doesn't need a new key).

emteknetnz commented 4 years ago

@robbieaverill done

Note there wasn't previously a 2 branch, I chatted with Garion and he agreed we should create a 2 branch off master to match conventions on other supported modules

I've created another pull request to update config https://github.com/silverstripe/silverstripe-elemental-fileblock/pull/16

robbieaverill commented 4 years ago

Nice, you could update your commit message too if you wanted to be semantically correct

emteknetnz commented 4 years ago

Have changed 'FIX' to 'API' in the commit message

robbieaverill commented 4 years ago

😄 it's more of an enhancement than an API change

emteknetnz commented 4 years ago

Have changed 'API' to 'NEW' :-)