silverstripe / silverstripe-elemental-fileblock

A file block for the dnadesign/silverstripe-elemental module
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

HTML showing in inline preview #39

Closed emteknetnz closed 1 year ago

emteknetnz commented 1 year ago

Happens in CMS 5, doesn't happen in CMS 4

image

Replicate steps:

PRs

GuySartorelli commented 1 year ago

This is happening because getSummary() is actually being used now, where in CMS 4 it wasn't. The summary should just be a plain-text summary.

sabina-talipova commented 1 year ago

We should probably remove the FileBlock::getSummaryThumbnail method and SummaryThumbnail.ss template file in the future as they are no longer needed. Update: If you check Summary Component in silverstripe-elemental you will see that there are no ways how to set HTML Elements and probably any HTML will be redundant there.

GuySartorelli commented 1 year ago

Bug fixes tagged on fileblock and bannerblock respectively as 3.0.2

GuySartorelli commented 1 year ago

All PRs merged