silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks
http://dna.co.nz
BSD 3-Clause "New" or "Revised" License
110 stars 115 forks source link

RFC Add elemental to the installer recipe #1025

Closed GuySartorelli closed 1 year ago

GuySartorelli commented 1 year ago

This module is the defacto way to add content to pages these days. It should be added to the installer recipe, either directly or as part of recipe-cms.

Note that it wouldn't make any sense to include this in the recipe without adding some default config - so we would need to agree on what the appropriate default config would be. I've listed two options here - if anyone can think of a different option I'll happily add it to this description for discussion.

Possible options:

Add a new page type

I don't personally like this option but I can see arguments for it.

Apply ElementalPageExtension to Page or SiteTree by default

This is my preferred option.

xini commented 1 year ago

I very strongly disagree with this. a) it presumes that every site uses elemental, which is very much not the case b) there are so many flaws and issues with elemental that it simply can't be pushed as a defacto standard

micschk commented 1 year ago

This module is the defacto way to add content to pages these days

I should hope not. Any evidence to support this claim/assumption?

In my experience, developing sites with Elemental quickly becomes an exercise in working around various ehrm 'issues'(?) as soon as you want anything out of the ordinary.

michalkleiner commented 1 year ago

Even though we used Elemental for nearly all our site builds and built quite a complex and rich boilerplate around it with what we commonly needed, I also think it should NOT be the default.

I would support making it as easy as possible to install and provide sane defaults like what is described in the RFC, but having it opt-in, not opt-out.

It reminds me of the CWP recipe where it was initially thought everyone would want the defaults like news page, events holders, footer holder page types etc., but they hardly ever worked for the majority of the projects our clients wanted, so it was more about having a way how to remove/hide all that and keep the bare minimum required.

lerni commented 1 year ago

I use elemental a lot but also have doubts it would be a good default. "elemental friction" like #945, #738, inline editing is hardly usable cos of to many things & fields that do not work, moving blocks to another page is not possible out of the box, virtual-element cannot be used for form-elements, handling around versioning & archive -> restoring an element is an exercise in pain cos probable an element has no title but you cannot make title a required field, anchor-linking is also not well supported, etc. The elemental experience ATM has too many rough edges to be default.

GuySartorelli commented 1 year ago

Sounds like we're not ready for this one yet. Closing.