search

silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks
http://dna.co.nz
BSD 3-Clause "New" or "Revised" License
110 stars 115 forks source link

RFC: Move ElementVirtualLinked to its own module #105

Closed robbieaverill closed 7 years ago

robbieaverill commented 7 years ago

Similar to #65, ElementVirtualLinked may not be ideal for everybody. Can it be moved to its own repo?

pitchandtone commented 7 years ago

Currently there's a fair bit of functionality within BaseElement in order to make Virtuals work which is why I left it in the module.

Options: Try split said functionality out (not sure how hard this will be) Keep most of the functionality on baseElement, but move VirtualElement to another repo (unsure if this is easy either) Leave as is

wilr commented 7 years ago

https://github.com/creative-commoners/silverstripe-elemental-virtual

wilr commented 7 years ago

@pitchandtone I don't have create repo rights for dnadesign but I imagine that this will sit on the DNA github long term. Let me know and I'll transfer it across. PR for the main repo coming soon.

wilr commented 7 years ago

Done. Put on the main repo https://github.com/silverstripe/silverstripe-elemental-virtual