Implement inline submitting elements on page/parent save

emteknetnz commented 2 months ago

This card is for the implementation of "Approach one" from SPIKE Look at solutions between field validation conflicting between block level and page level

Issues this resolves

Questions:

Do we want green toast notifications for individual content blocks published when page is published? (e.g. you'll get three green toasts on page save if two elements are saved)
Do we want red toast notifications for individual content blocks published when they fail validation? (currently there are no red toasts)
Do we want to block saving individual elements until all elements are valid? (Would be significantly more complex, need validation endpoints)

Acceptance criteria

[ ] Elements with a dirty form state are inline saved when the page/parent save/publish button is clicked
[ ] The page/parent save/publish is blocked when there are validation errors with one or more of the elements that were inline saved
[ ] Solution works with
- [ ] ElementalAreas on Pages
- [ ] ElementalAreas on non-page DataObjects
- [ ] Multiple ElementalAreas on one form
[ ] Elements are still cascade published on parent publish
[ ] PHP logic for handling saving elemental data on page/parent save is no longer called and formally deprecated.
[ ] If viable, stop submitting elemental data on page/parent save with POST request.

Note

We've thought about adding an opt-out for the new behaviour but decide against it under the assumption people would have had to customise the individual block save anyway.
Our testing team has offered to help regression test the recent elemental work prior to the beta. Follow up with them once this card is done.

Shared CI run (elemental endtoend) are the relevant jobs)

https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/10071368437

Notes:

The elemental endtoend job is the relevant one
I cannot replicate any of the other endtoend failures locally
The phpunit failures are unrelated

PRs

Test PRs

https://github.com/silverstripe/silverstripe-admin/pull/1796

GuySartorelli commented 1 month ago

PRs merged.

There's a note in the issue description that says

Our testing team has offered to help regression test the recent elemental work prior to the beta. Follow up with them once this card is done.

Reassigning to Steve to do that.

emteknetnz commented 1 month ago

Have contacted testing team regrading this, will close this issue now that the PRs have been merged. We'll deal with any regressions found by the testing team in a separate issue

silverstripe / silverstripe-elemental

Implement inline submitting elements on page/parent save #1215