silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks
http://dna.co.nz
BSD 3-Clause "New" or "Revised" License
109 stars 115 forks source link

ENH Add `$startIndex` param to `Pos` method #1222

Closed nedmas closed 1 month ago

nedmas commented 1 month ago

Description

I've added $startIndex param to the Pos method with a default value of 1.

Manual testing steps

Loop through elements in an elemental area and print the results of $Pos(1).

Issues

Pull request checklist

michalkleiner commented 1 month ago

Just curious @nedmas, based on what did you check the CI is green item in the checklist? The CI for this PR hasn't run yet.

nedmas commented 1 month ago

Just curious @nedmas, based on what did you check the CI is green item in the checklist? The CI for this PR hasn't run yet.

So honestly I just marked it complete because I got overwhelmed by the amount of stuff I was required to read/do just to add a minor PR. Tried my best but I guess I got it wrong :smiley: Out of interest what should I have done? So I know for next time.