search

silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks
http://dna.co.nz
BSD 3-Clause "New" or "Revised" License
110 stars 115 forks source link

Duplicating Page causes the two pages to share blocks. #179

Closed asecondwill closed 6 years ago

asecondwill commented 6 years ago

Duplicating a page has caused the original and new page to forever share blocks, so changes in one causes changes in the other. Quite dangerous as if you then leap into the duplicate and start deleting things ready to make changes, you have just ruined the original page.

robbieaverill commented 6 years ago

Hi @asecondwill, thanks for reporting. Can you please provide the versions of SilverStripe and the elemental module that you're using?

robbieaverill commented 6 years ago

Please feel free to reopen with the required info to reproduce =)

bummzack commented 6 years ago

This happens to me as well:

silverstripe/recipe-cms 1.1.0
dnadesign/silverstripe-elemental 2.0.0

Steps to reproduce: Create a page, add Elements to it. Duplicate page.

thats4shaw commented 6 years ago

I've also struck this.

Same module versions as @bummzack.

robbieaverill commented 6 years ago

Thanks

robbieaverill commented 6 years ago

Implementing the $cascade_duplicates ownership API configuration in SilverStripe 4.1 fixes this problem. I'm going to bump the minimum SS version to 4.1 for the next minor release of elemental and implement these changes.

robbieaverill commented 6 years ago

PR at #217

digitall-it commented 6 years ago

Sorry to reopen, do you think this also affects Elemental v1.x release line?

robbieaverill commented 6 years ago

The SS3 version has its own duplication logic. If you find a problem with it feel free to reopen =)