silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks
http://dna.co.nz
BSD 3-Clause "New" or "Revised" License
110 stars 115 forks source link

Readonly view #181

Closed chillu closed 6 years ago

chillu commented 6 years ago

Overview

Readonly block views become important for viewing history of a page with all of its blocks. Currently that's not working. The SS4 page history only shows a "none" label, even with two (published) content blocks associated to that version.

image

Acceptance Criteria

Notes

robbieaverill commented 6 years ago

It’s worth noting that block history does work, just not page history at this point

robbieaverill commented 6 years ago

I just tested the history for blocks on SS 4.1 and there have been some regressions. Will isolate and log an issue shortly.

NightJar commented 6 years ago

Just adding tests for the PR at https://github.com/dnadesign/silverstripe-elemental/pull/224

robbieaverill commented 6 years ago

Done in https://github.com/silverstripe/silverstripe-admin/pull/511 and #224