search

silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks
http://dna.co.nz
BSD 3-Clause "New" or "Revised" License
110 stars 115 forks source link

Split out Text Checkbox Group Field #227

Open mak001 opened 6 years ago

mak001 commented 6 years ago

Can DNADesign\Elemental\Forms\TextCheckboxGroupField be split out into its own module? I can see this being useful in some other modules that would not need elemental.

muskie9 commented 6 years ago

@robbieaverill I can start this if you want to create a repository with an initial commit. We have a project we'd pull in the new module that we're wrapping up an initial build for so might be good timing.

robbieaverill commented 6 years ago

cc @brynwhyman - the React elemental rewrite would be a good opportunity to get this done

brynwhyman commented 6 years ago

@robbieaverill good idea. @muskie9, I realise it's been a couple months but would you still be willing to help start this off? If so, we'll get this done sooner rather than later.

muskie9 commented 6 years ago

Sorry for the radio silence, I plan on getting back to this over the next week.

muskie9 commented 6 years ago

Just curious if anyone else has experience the field laying out a bit odd currently. I think it's in v2, but seems to be fine in v3. I'll try to get a screenshot of this, but wasn't sure if anything changed between those versions for that field.

Additionally, what branch should this PR go against. I have it about 2/3 done at this point and have a long weekend coming up so hoping to get it to a state to open the PR.

robbieaverill commented 6 years ago

@muskie9 yeah there is a slightly different set of CSS classes between Bootstrap 4.0.0 beta and stable (which changed between SilverStripe 4.0/4.1 and 4.2 I think). That could be it. Related issue: https://github.com/dnadesign/silverstripe-elemental/issues/201

what branch should this PR go against

In this repository, master since it's a breaking change.

I'm discussing internally about what the repository that the field goes into should be called.

Thanks for doing this!

robbieaverill commented 6 years ago

@muskie9 I've created https://github.com/silverstripe/silverstripe-checkboxgroupfield as a new repository for this change

muskie9 commented 6 years ago

Thanks @robbieaverill, would you be able to do a quick README, I'm unable to fork it at this time with no files present.

robbieaverill commented 6 years ago

Sorry @muskie9, I've added an empty readme

muskie9-opensource commented 2 years ago

@robbieaverill I deeply apologize for the drop-off with this ticket and subsequently the repository. I do think this is still something valuable in the community as we have all become accustomed to a "value and/or show" type of structure with elemental.

I'd love to pick this back up, however I want to check if https://github.com/silverstripe/silverstripe-checkboxgroupfield is still a valid place for that. I recall digging in a bit and the expectation of field to save is a bit of work which is fine, I just want to be sure we're setting this where it's most accessible to the community as it is completed and is stable.

Again, sorry for the complete drop-off with this ticket, I'm glad it didn't get closed due to it's staleness.