Closed brynwhyman closed 6 years ago
Blocks: https://invis.io/T7NLP7WP3K4 Layout blocks: https://invis.io/BNNLP87VQJU
I looked into this for a bit today and have come across a few issues to be aware of. While e.g. adding box-shadow:$z-depth-2;
adds a horizontal drop shadow to the element, no vertical shadow is rendered it falls outside the visible React app area:
I tried a workaround of adding a vertical margin, whilst reducing the vertical padding to prevent the content from 'jumping', but the result is far from the design:
Browser compatibility will need to be tested, especially on IE and Edge, as there are some pre-existing issues - e.g. https://github.com/dnadesign/silverstripe-elemental/issues/358 - that not only extend functionality, but also style. Using the pseudo-elements :hover
, :focus
, and focus:within
did not cause the element to change its apparence when tabbed into via keys.
Closed via #361
User Story
As a CMS user, I want an indication of which block preview is expected to be selected, so that I can confirm I’m focusing on the correct block preview before clicking it.
Acceptance Criteria
Pull requests