Display versioned state of elements in react-based page

silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks

http://dna.co.nz

BSD 3-Clause "New" or "Revised" License

110 stars 115 forks source link

Display versioned state of elements in react-based page #276

Closed brynwhyman closed 6 years ago

brynwhyman commented 6 years ago

Ensure that the versioned state of blocks are returned to the blocks page.

This has been sub-tasked out from #272 due to the dependancies of two bugs: ~https://github.com/silverstripe/silverstripe-graphql/issues/153#issuecomment-408735721 and~ https://github.com/silverstripe/silverstripe-versioned/issues/147#issuecomment-408736435

robbieaverill commented 6 years ago

I've triaged this in a way that assumes the blockers have been resolved

raissanorth commented 6 years ago

Does this ticket include the indicators that content is saving, publishing etc.?

I made a PR - https://github.com/dnadesign/silverstripe-elemental/pull/374 - that contains changes to indicate to users if blocks are published/modified/draft. But now I've gotten access to these designs https://assets.v7-io.invisionapp.com/assets/A_MGFjZjlkZDY2YjhlM2JmOZaPaMZblkh6tsmq9GKEyHH9PAcKTwOx0NjC89x7SsGLzsUh3PjYwR0UymNWhIAyGI1BGstJKyjGQdXG0LAW3JFS5YNXBGjUyaauNDkEIVRlifl7ypHgWLrbXT0N4eWUFGH9n4g9t-nod4lNgkOvQp7GisdcvfX6B-1FH2O8PYunRO9syUBY6xk65C9SHqYLJA==

raissanorth commented 6 years ago

@robbieaverill Do you reckon we can close this and open up another ticket for saving/publishing indicators - since the former hasn't been implemented yet and therefore blocks this otherwise?

robbieaverill commented 6 years ago

Yeah totally, what you've done is what we didn't do last time and why we created this ticket. The indicators were new features as far as I remember.

Done in #374 - thanks @raissanorth