Options menu doesn't expand block in correct tab

silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks

http://dna.co.nz

BSD 3-Clause "New" or "Revised" License

110 stars 115 forks source link

Options menu doesn't expand block in correct tab #453

Closed brynwhyman closed 6 years ago

brynwhyman commented 6 years ago

When inline editing is enabled for a block on master and the block is collapsed, when selecting a tab option in the options menu, the block will always expand on the content tab regardless of the selection. It should expand on the tab that was selected.

Reproduce:

Select 'Settings' from the options menu on a collapsed block
Notice that the block expands to the content tab, not the settings tab

brynwhyman commented 6 years ago

robbieaverill commented 6 years ago

I merged a bunch of PRs from @raissanorth today, then re-tested and this is working now. Please feel free to reopen again @brynwhyman if you experience it again with the latest master branch of elemental. You'll need to update your other dependencies as well (composer update).