silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks
http://dna.co.nz
BSD 3-Clause "New" or "Revised" License
110 stars 115 forks source link

History styling is off: Caret on the history "View Block" link is incorrect & font sizing issues #509

Closed ScopeyNZ closed 5 years ago

ScopeyNZ commented 6 years ago

Affected Versions:

3.x, 4.x

Description

Firstly the "View Block" link:

The font-icon is too small.

image

The underline on hover shouldn't go under the icon:

image

Designs:

image

(Note that this was originally intended to link to history of the individual block. Currently this only goes to edit the draft version of the block. The new wording is correct)

The font size issue:

The titles of the various fields seem to have a non-standard smaller font-size:

image

Steps to reproduce

cc @sachajudd Reference: https://github.com/dnadesign/silverstripe-elemental/issues/223

ScopeyNZ commented 5 years ago

PR at #618

ScopeyNZ commented 5 years ago

The font size issue:

The titles of the various fields seem to have a non-standard smaller font-size:

I missed this. While this could be a problem with Elemental - it could also be a problem in admin.

I've put all my thoughts in a new issue: #620.

robbieaverill commented 5 years ago

Fixed in #618