Cannot create new versions of the page after modifying block content

silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks

http://dna.co.nz

BSD 3-Clause "New" or "Revised" License

110 stars 115 forks source link

Cannot create new versions of the page after modifying block content #530

Closed robbieaverill closed 5 years ago

robbieaverill commented 5 years ago

Version: SS 4.3.x-dev and elemental 3.2.x-dev

Create a page
Add a block to the page
Set some content for the block and save
Go back to the page and publish it
Edit the block and update its content
Go back to the page and publish it
Go to the history tab

Expected: there should be two Published versions of the page listed

Actual: there is only the initial Published version of the page listed

I suspect this is a manifestation of #527 and #528

ScopeyNZ commented 5 years ago

There has been plenty of discussion in silverstripe-versioned about this issue: https://github.com/silverstripe/silverstripe-versioned/issues/195

I think it's probably fair to close this as a duplicate of that issue? You could possibly argue that you should be allowed to create a published version of a page at any time so the timestamp is atleast captured for showing history related to that timestamp. Perhaps that'd be an issue on CMS though if it's not currently possible?

robbieaverill commented 5 years ago

Yeah this particular issue I think is happening because when you click Save on the page, it doesn't detect any new changes so doesn't write a new version (default behaviour).

Projects implementing elemental and wanting to disable this could probably create an extension for the CMS controller and adjust the save logic to force a new version.

Otherwise this would be resolved by fixing that issue, yeah