Behat builds are broken (FormBuilder init'd TinyMCE is broken in SS 4.4)

silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks

http://dna.co.nz

BSD 3-Clause "New" or "Revised" License

110 stars 115 forks source link

Behat builds are broken (FormBuilder init'd TinyMCE is broken in SS 4.4) #563

Closed robbieaverill closed 5 years ago

robbieaverill commented 5 years ago

See:

robbieaverill commented 5 years ago

I've done a merge up from 4.0 to master and fixed the conflicts - that might help to fix behat, which is passing in the 4.0 branch: b91912a

robbieaverill commented 5 years ago

Nope, didn't fix it. OK it turns out the Behat failures are showing a real bug - you can't save TinyMCE editor values via inline editing. I've tested that without elemental and raised an issue for it here: https://github.com/silverstripe/silverstripe-admin/issues/802

brynwhyman commented 5 years ago

I'm happy to keep this as impact/critical but it's worth noting that the bug is only present in SS 4.4.x-dev due to the introduction of React 16, which is yet to be released.

robbieaverill commented 5 years ago

Downgraded impact rating since the main bug is fixed. The banner block builds are still broken but I think it's something else.

robbieaverill commented 5 years ago

Fixed with https://github.com/silverstripe/silverstripe-elemental-bannerblock/pull/25