silverstripe / silverstripe-elemental

Create pages in Silverstripe CMS using content blocks

http://dna.co.nz

BSD 3-Clause "New" or "Revised" License

110 stars 115 forks source link

Adjust order of actions in the options dropdown #707

Closed clarkepaul closed 5 years ago

clarkepaul commented 5 years ago

The order of the actions in the dropdown has changed recently? It should be:

Save
Publish
Unpublish
Unpublish and archive

Pull request

[ ] https://github.com/dnadesign/silverstripe-elemental/pull/717

brynwhyman commented 5 years ago

'Unpublish and archive" is expected to be implemented in #678

maxime-rainville commented 5 years ago

@clarkepaul To rename "Archive" to "Unpublish and archive", I'll have to bump up the width of the action menu. Let me know if this is problematic for you

Current width

Suggested new width

clarkepaul commented 5 years ago

Seeing as the label is quite long I'd actually prefer if we kept the label as "Archive" and the success message changes to say something like "Successfully unpublished and archived".

I think users would be expecting it to be removed from the site anyway.

FYI this is the wording we use for archiving pages, the action is using the long label but I think we can shorten it there too...

robbieaverill commented 5 years ago

Can that be covered in #678? I've merged the PR for this issue