search

silverstripe / silverstripe-externallinks

Module which tracks external broken links in Silverstripe CMS pages
BSD 3-Clause "New" or "Revised" License
10 stars 12 forks source link

Include broken links from content blocks #68

Open brynwhyman opened 4 years ago

brynwhyman commented 4 years ago

Overview

Currently this report will not include any external broken links that are included in elemental content blocks. As content blocks become a very popular method of creating content, this report should be tracking this content too.

We've seen a similar enhancement (with an open PR) to the elemental content blocks module to ensure that content is being included in the 'Broken page' and 'Broken links' reports, see https://github.com/dnadesign/silverstripe-elemental/issues/689

ACs

Notes

PR's

brynwhyman commented 4 years ago

I still want to check if there's a UI change to broken links in a WYSIWYG after this report is run (i.e. the link is highlighted) as we may need an AC around this.

robbieaverill commented 4 years ago

Yes, it's supposed to highlight broken links with a red underline

brynwhyman commented 4 years ago

Thanks @robbieaverill. I've added another AC to reflect this:

  • Running the report should result in broken links being highlighted in the WYSIWYG as 'broken'. Note this is existing behaviour for pages, so the aim is to match this functionality.
brynwhyman commented 4 years ago

Related/ duplicate: https://github.com/silverstripe/silverstripe-externallinks/issues/37

brynwhyman commented 4 years ago

There's a similar issue which we've previously triaged as a bug: https://github.com/dnadesign/silverstripe-elemental/issues/689

brynwhyman commented 4 years ago

Noting that a recent bug was raised for CMS job run for this report. This should be reviewed when this issue is picked up: https://github.com/silverstripe/silverstripe-externallinks/issues/69