silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
720 stars 823 forks source link

FIX Match multi-line JOIN statements #10960

Closed GuySartorelli closed 11 months ago

GuySartorelli commented 11 months ago

This bug was introduced in https://github.com/silverstripe/silverstripe-framework/pull/10953 The error was caused by not accounting for JOIN clauses that span multiple lines - so the query builder thought the JOIN was actually a table name.

Because this was causing failure in multiple modules, I've created a full installer CI run: https://github.com/creative-commoners/silverstripe-installer/actions/runs/6304821057

Issue