search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
721 stars 821 forks source link

Update URLSegmentFilter default_replacement ordering #10976

Closed thats4shaw closed 10 months ago

thats4shaw commented 1 year ago

Issue https://github.com/silverstripe/silverstripe-framework/issues/11045

Forward slashes, question marks, equal signs, hashes and colons were never actually being replaced with hyphens due to the order of the default_replacements array.

The regex rule before it was always blasting it away.

emteknetnz commented 10 months ago

Hi, just letting you know this PR will be closed shortly unless there's further work done on it

thats4shaw commented 10 months ago

@emteknetnz feel free to close if you must as its unlikely I'll be able to prioritize as I don't have a single minute spare at the moment.