search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
720 stars 823 forks source link

TODO: Controller::beforeHandleRequest improvements #10981

Closed sabina-talipova closed 10 months ago

sabina-talipova commented 10 months ago

Description

Investigate how we can improve Controller::beforeHandleRequest since setRequest is redundantly called in parent::handleRequest().

See: https://github.com/silverstripe/silverstripe-framework/blob/cbd358ab93094a2ad0271d3600b94bb3f1899719/src/Control/Controller.php#L149

GuySartorelli commented 10 months ago

Gonna close this since it's a very very minor code smell that isn't causing any real problems.