search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
721 stars 821 forks source link

Non-public dir support was removed in CMS 5.0.0 - remove dead code #10983

Open sabina-talipova opened 1 year ago

sabina-talipova commented 1 year ago

Description

Changes need to be made to SimpleResourceURLGenerator::resolveModuleResource as Non-public directories are no longer supported in CMS 5. There's a block here that only applies if there's no public directory.

See: https://github.com/silverstripe/silverstripe-framework/blob/cf78a9d785b9959a92dfb52c2a456bea80a4c567/src/Control/SimpleResourceURLGenerator.php#L143

Note

We need to consider what happens for usage of framework that isn't using a web server (e.g. pure CLI apps)