search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
721 stars 821 forks source link

TODO: CsvBulkLoader::findExistingObject - support $columnMap #10995

Closed sabina-talipova closed 11 months ago

sabina-talipova commented 1 year ago

Description

CsvBulkLoader::findExistingObject takes $columnMap as second argument, but method doesn't use it. We should investigate do we still need this argument and if so implement logic to support $columnMap.

See: https://github.com/silverstripe/silverstripe-framework/blob/cf78a9d785b9959a92dfb52c2a456bea80a4c567/src/Dev/CsvBulkLoader.php#L292

GuySartorelli commented 11 months ago

Gonna close this one - there's no clear way to use it there and we aren't likely to get around to investigating this.

sabina-talipova commented 11 months ago

Open new ticket to remove this argument in CMS6