search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
720 stars 822 forks source link

Provide better feedback when using CsvBulkLoader #10996

Open sabina-talipova opened 9 months ago

sabina-talipova commented 9 months ago

Description

We pass message as empty string in BulkLoader_Result::addUpdated from CsvBulkLoader::processRecord (See). We must pass a more clear message to the addUpdated method, or delete this variable from processRecord , since the method addUpdated uses null by default.

See:

Note that this message is (or is supposed to be) displayed in the form modal which is used to trigger the bulk action.

GuySartorelli commented 9 months ago

@sabina-talipova The description doesn't seem related to the issue title or the links - can you please check this one? I think it got mixed up with https://github.com/silverstripe/silverstripe-framework/issues/10995

sabina-talipova commented 9 months ago

~~Based on your post here. If we are not going to add support of $columnMap in CsvBulkLoader::findExistingObject, than I think we can close this ticket as well and open another one to remove parameter from both "methods signature".~~

GuySartorelli commented 9 months ago

Sounds like a plan

sabina-talipova commented 9 months ago

Sorry, I copied description from another ticket by accident. I've update description again. I reopen ticket.