TODO: Replace GroupedDropdownField::schemaDataType with 'SCHEMA_DATA_TYPE_*' constant

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS

https://www.silverstripe.org

BSD 3-Clause "New" or "Revised" License

720 stars 822 forks source link

TODO: Replace GroupedDropdownField::schemaDataType with 'SCHEMA_DATA_TYPE_*' constant #11005

Closed sabina-talipova closed 9 months ago

sabina-talipova commented 9 months ago

Description

Replace the hardcoded "GroupedDropdownField" string with a new SCHEMA_DATATYPE* constant

See TextField::$schemaDataType for an example.

See: https://github.com/silverstripe/silverstripe-framework/blob/cf78a9d785b9959a92dfb52c2a456bea80a4c567/src/Forms/GroupedDropdownField.php#L58-L59

GuySartorelli commented 9 months ago

Gonna close this - I honestly think we should go in the other direction and remove a bunch of those constants instead - but that would be a different issue.