Actually test validation of `RequiredFields` validator

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS

https://www.silverstripe.org

BSD 3-Clause "New" or "Revised" License

720 stars 822 forks source link

Actually test validation of `RequiredFields` validator #11011

Open sabina-talipova opened 9 months ago

sabina-talipova commented 9 months ago

Description

RequiredFieldsTest performs lots of tests for methods on RequiredFields - but it doesn't actually test the validation which is probably the one thing we have to test.

See: https://github.com/silverstripe/silverstripe-framework/blob/cf78a9d785b9959a92dfb52c2a456bea80a4c567/tests/php/Forms/RequiredFieldsTest.php#L9