search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
721 stars 821 forks source link

TODO: Investigate possibility to move Member::beforeMemberLoggedIn into AuthenticationMiddleware #11016

Closed sabina-talipova closed 11 months ago

sabina-talipova commented 11 months ago

Description

Investigate possibility to move Member::beforeMemberLoggedIn to middleware on the AuthenticationMiddleware IdentityStore.

See: https://github.com/silverstripe/silverstripe-framework/blob/cf78a9d785b9959a92dfb52c2a456bea80a4c567/src/Security/Member.php#L449

GuySartorelli commented 11 months ago

Gonna close this one as it is working fine as is, and there's no clear benefit to moving it.