TODO: DataObject::merge - remove redundant merge of has_one fields

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS

https://www.silverstripe.org

BSD 3-Clause "New" or "Revised" License

721 stars 821 forks source link

TODO: DataObject::merge - remove redundant merge of has_one fields #11025

Closed sabina-talipova closed 11 months ago

sabina-talipova commented 11 months ago

Description

DataObject::merge - remove redundant merge of has_one fields.

See: https://github.com/silverstripe/silverstripe-framework/blob/cf78a9d785b9959a92dfb52c2a456bea80a4c567/src/ORM/DataObject.php#L1154

GuySartorelli commented 11 months ago

Gonna close this one because it's not clear where the redundant merge is, but it also wouldn't be a dramatic improvement anyway. IMO not worth the time to look into it further.