TODO: DataObject::setFieldValue improvememnts

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS

https://www.silverstripe.org

BSD 3-Clause "New" or "Revised" License

720 stars 822 forks source link

TODO: DataObject::setFieldValue improvememnts #11027

Closed sabina-talipova closed 9 months ago

sabina-talipova commented 9 months ago

Description

If a field is not existing or has strictly changed:

Add check for php-level defaults which are not set in the db
Add check for hidden input-fields (readonly) which are not set in the db

See: https://github.com/silverstripe/silverstripe-framework/blob/cf78a9d785b9959a92dfb52c2a456bea80a4c567/src/ORM/DataObject.php#L2908-L2909

GuySartorelli commented 9 months ago

@sabina-talipova Do you know what is meant by "php-level defaults which are not set in the db"? Or "hidden input-fields (readonly) which are not set in the db"? I'm not sure what either of those are in this context.

sabina-talipova commented 9 months ago

Probably we can close this ticket, since It's existing since 2016 and probably it was there even early. And I think it's not actual any more.