search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
720 stars 822 forks source link

TODO: DBSchemaManager::requireTable - Change detection for `CREATE TABLE $options other than "ENGINE"` #11028

Closed sabina-talipova closed 9 months ago

sabina-talipova commented 9 months ago

Description

DBSchemaManager::requireTable - Change detection for CREATE TABLE $options other than "ENGINE"

See: https://github.com/silverstripe/silverstripe-framework/blob/cf78a9d785b9959a92dfb52c2a456bea80a4c567/src/ORM/Connect/DBSchemaManager.php#L353

GuySartorelli commented 9 months ago

@sabina-talipova Do you know what this todo is actually asking for? It seems like one we might not have enough context for, and should perhaps close.

sabina-talipova commented 9 months ago

I assume it's related to this part of the code: https://github.com/silverstripe/silverstripe-framework/blob/cf78a9d785b9959a92dfb52c2a456bea80a4c567/src/ORM/Connect/DBSchemaManager.php#L390-L396

I'm not sure that is still actual.

GuySartorelli commented 9 months ago

We aren't aware of any limitations or problems caused by the current implementation - I'd rather not poke the bear.