search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
720 stars 822 forks source link

The $columnMap argument is no longer required in CsvBulkLoader::findExistingObject #11036

Open sabina-talipova opened 9 months ago

sabina-talipova commented 9 months ago

Description

CsvBulkLoader::findExistingObject method receives array $columnMap as second argument, but never use it. We should mark argument $columnMap as deprecated and remove it from the method in version CMS 6. We also should remove this variable everywhere where we invoke CsvBulkLoader::findExistingObject method.

Related issue