search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
719 stars 820 forks source link

URLSegmentFilter is replacing too many characters #11045

Open emteknetnz opened 8 months ago

emteknetnz commented 8 months ago

Originally reported by @thats4shaw

Forward slashes, question marks, equal signs, hashes and colons were never actually being replaced with hyphens due to the order of the default_replacements array.

The regex rule before it was always blasting it away.

PRs

GuySartorelli commented 7 months ago

@emteknetnz I've updated the issue description to include the information from the PR. Please try to avoid issues that just say "parent issue for " - it's a simple matter to copy the relevant information to the issue, and then the issue itself has some value beyond just being on a board.