silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
719 stars 820 forks source link

Don't remove the `GridFieldFilterHeader` from `GridFieldConfig_RecordViewer` #11070

Open GuySartorelli opened 7 months ago

GuySartorelli commented 7 months ago

The GridFieldConfig_RecordViewer config removes GridFieldFilterHeader for some reason.... but there's no reason to remove it. Most of the time you'll want to be able to filter your gridfield. Adding that component back in requires first removing the paginator, then adding the filter header, then adding the paginator back in...

We should just not remove the GridFieldFilterHeader component. Unfortunately that would be a breaking change as people will currently have code that assumes that component isn't there.

Acceptance criteria