Unused code in `FieldList::findTab()`

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS

https://www.silverstripe.org

BSD 3-Clause "New" or "Revised" License

719 stars 820 forks source link

Unused code in `FieldList::findTab()` #11090

Closed edwilde closed 6 months ago

edwilde commented 7 months ago

Affected Version

5.1.8

Description

Spotted this line of code, seems redundant. Not super important in the grand scheme of things, but I will raise a PR to remove it. I assume copy/paste from the findOrMakeTab() method which does use it.

edwilde commented 7 months ago

Ah, gee...the $last_idx line is also unused

GuySartorelli commented 6 months ago

PR merged. Thanks for helping tidy things up 🥳