FIX Unknown column 'ClassName' in field list

lekoala commented 4 months ago

Fixes https://github.com/silverstripe/silverstripe-framework/issues/10737

Description

See related issue

Manual testing steps

See related issue

Issues

https://github.com/silverstripe/silverstripe-framework/issues/10737

Pull request checklist

[x] The target branch is correct
- See picking the right version
[x] All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
- Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
[x] The commit messages follow our commit message guidelines
[x] The PR follows our contribution guidelines
[x] Code changes follow our coding conventions
[] This change is covered with tests (or tests aren't necessary for this change)
[x] Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
[x] CI is green

lekoala commented 4 months ago

So this is a first attempt to get the ball rolling Ignoring the case clause is the easy way to prevent the error it would be better to make the actual join, but that would require more analysis to know what is the relation being used in that case, not exactly sure how/when to do that

lekoala commented 4 months ago

Seems sensible - if I'm understanding this code correctly, it shouldn't introduce new potential collisions, since this table isn't being included in the table anyway and therefore couldn't collide with anything?

that's the idea. it seems to work just fine in my case and the field has the right value (in my case, it's a MemberID ...)

lekoala commented 4 months ago

any other wishes? :)

michalkleiner commented 4 months ago

any other wishes? :)

I'd like a trip to Bali, thanks!

silverstripe / silverstripe-framework