MNT Remove unexpected coupling with admin for test - Githubissues

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS

https://www.silverstripe.org

BSD 3-Clause "New" or "Revised" License

722 stars 821 forks source link

MNT Remove unexpected coupling with admin for test #11136

Closed GuySartorelli closed 7 months ago

GuySartorelli commented 7 months ago

This was introduced in https://github.com/silverstripe/silverstripe-framework/pull/11114 so I'm targetting 5.1, even though the broken CI run was on 5. I tested it in 5 and it does resolve that failure.

Fixes https://github.com/silverstripe/recipe-core/actions/runs/7854511547/job/21501300422

1) SilverStripe\Forms\Tests\HTMLEditor\HTMLEditorFieldTest::testGetAttributes
Exception: If the silverstripe/admin module is not installed you must set the TinyMCE path in SilverStripe\Forms\HTMLEditor\TinyMCEConfig.base_dir

Issue

https://github.com/silverstripe/.github/issues/195