search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
719 stars 820 forks source link

MNT Ensure composer/semver installed or skip test #11166

Closed emteknetnz closed 4 months ago

emteknetnz commented 4 months ago

Issue https://github.com/silverstripe/.github/issues/207

Fixes https://github.com/silverstripe/silverstripe-installer/actions/runs/8131709640/job/22225347023

1) SilverStripe\Core\Tests\Manifest\VersionProviderTest::testGetModuleVersion Error: Class "Composer\Semver\VersionParser" not found

composer/semver was originally added as require-dev in https://github.com/silverstripe/silverstripe-framework/pull/11157

Also fixes https://github.com/silverstripe/recipe-core/actions/runs/8110522366/job/22167949864#step:12:162

1) SilverStripe\Core\Tests\Manifest\VersionProviderTest::testGetVersion OutOfBoundsException: Package "silverstripe/siteconfig" is not installed

Which breaks in silverstripe/recipe-core because silverstripe/siteconfig isn't installed - presumably it was erroneously passing before