silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
719 stars 820 forks source link

Improve phpdoc types #11173

Closed lekoala closed 1 month ago

lekoala commented 3 months ago

Description

I'd like to make the codebase easier to use with phpstan

Additional context or points of discussion

See here for more details: https://github.com/silverstripe/silverstripe-framework/issues/11149

Validations

PRs

GuySartorelli commented 3 months ago

I've merged the linked PR. @lekoala are there additional docblock types you want to update? Or should I close this issue as complete?

lekoala commented 3 months ago

@GuySartorelli you can leave this open, i have a few others coming up but I'm rather in a rush at the moment so that could take a few weeks

GuySartorelli commented 1 month ago

Since there haven't been any new PRs related to this in a while I'll close it. @lekoala if you end up raising new PRs that are related to this feel free to @ me and I'll reopen it so we can track those.