Invalid french translation in ChangePasswordEmail - Githubissues

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS

https://www.silverstripe.org

BSD 3-Clause "New" or "Revised" License

719 stars 820 forks source link

Invalid french translation in ChangePasswordEmail #11189

Closed lekoala closed 2 months ago

lekoala commented 3 months ago

Module version(s) affected

5.x

Description

The current translation is not accurate and very misleading. It should be 'Vous avez modifié votre mot de passe pour'. I added that translation on transifex

https://github.com/silverstripe/silverstripe-framework/blob/39c9e0d31c076565e56e4799d2e2dc4980fd9283/lang/fr.yml#L10

Is this merged automatically or should there be some kind of PR on the fr.yml file?

How to reproduce

When you get the reset email in french, it should not say "Your password is now : $SiteConfig.Title" which is ridiculous :)

Possible Solution

No response

Additional Context

No response

Validations

[X] Check that there isn't already an issue that reports the same bug
[X] Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

GuySartorelli commented 2 months ago

Please make any corrections to translations in transifex.com - see the contributing translations docs for more details. We don't manage translations through GitHub issues and PRs except for making strings localisable in the first place.