ENH add nullable return types

lekoala commented 2 months ago

Description

More phpdoc updates

Don't merge yet, more updates are coming related to date fields

Issues

https://github.com/silverstripe/silverstripe-framework/issues/11173

Pull request checklist

[x] The target branch is correct
- See picking the right version
[x] All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
- Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
[x] The commit messages follow our commit message guidelines
[x] The PR follows our contribution guidelines
[x] Code changes follow our coding conventions
[x] This change is covered with tests (or tests aren't necessary for this change)
[x] Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
[x] CI is green

GuySartorelli commented 2 months ago

Setting to draft since it says not to merge it yet

GuySartorelli commented 2 months ago

As a general rule, please try to avoid creating a PR which isn't ready to merge yet. We're a lot more likely to notice a new PR (and start looking at it) than we are to notice updates to an existing PR.

lekoala commented 2 months ago

@GuySartorelli didn't get the time to make the other changes i was planning to so this can be merged as is, i will reopen a new one when i find the time to make more improvements

silverstripe / silverstripe-framework