ENH add support for expanded values on Time/DateField

lekoala commented 5 months ago

Description

Currently, partial values in date/time field will results in null values. This is a bit annoying for time value (input 18:--:-- will be null) but is even more obvious on datetime field (inputing the date without the time results in null)

Manual testing steps

Only input partial values, it still submit properly

Issues

https://github.com/silverstripe/silverstripe-framework/issues/11172

Pull request checklist

[ ] The target branch is correct
- See picking the right version
[ ] All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
- Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
[ ] The commit messages follow our commit message guidelines
[ ] The PR follows our contribution guidelines
[ ] Code changes follow our coding conventions
[ ] This change is covered with tests (or tests aren't necessary for this change)
[ ] Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
[ ] CI is green

lekoala commented 5 months ago

Still work in progress

the basic idea would be to add some kind of common helper

    private function expandValue(?string $value, IntlDateFormatter $formatter): int|false
    {
        $zeroFormat = $formatter->format(strtotime(date('Y-01-01 00:00:00')));
        $expectedLength = strlen($zeroFormat);
        if (strlen($value) >= $expectedLength) {
            return false;
        }
        $expandedValue = $value . substr($zeroFormat, strlen($value));
        return $formatter->parse($expandedValue);
    }

i realize that there are many cases where you can setValue, setSubmittedValue, convert from frontend to internal, tidy internals, ... it's not always super consistent and basically i'd like partial values to work everywhere without too much issues

GuySartorelli commented 4 months ago

@lekoala Are you still keen to work on this? It seems like it'd be a really useful feature.

GuySartorelli commented 1 month ago

I'm going to close this for now as there hasn't been any action for a few months. Feel free to open a new PR once this is ready for review.

silverstripe / silverstripe-framework