Because this PR targets 5.2 which is currently in a change freeze, @maxime-rainville needs to approve it before it can be merged.
I am targetting 5.2 because it is the first minor release which includes multi-relational has_many relations, which is what has surfaced this as a problem (more details in the issue).
Description
polymorphic has_many relations create a query that is too ambiguous - depending on what you join into the query, the {relation}Class and {relation}Relation columns might be on multiple tables.
IMPORTANT
Because this PR targets
5.2which is currently in a change freeze, @maxime-rainville needs to approve it before it can be merged.I am targetting
5.2because it is the first minor release which includes multi-relational has_many relations, which is what has surfaced this as a problem (more details in the issue).Description
polymorphic has_many relations create a query that is too ambiguous - depending on what you join into the query, the {relation}Class and {relation}Relation columns might be on multiple tables.
This PR specifies the table that should be used.
Manual testing steps
See reproduction steps in the issue
Issues