Add support for polymorphic has_one to eager loading - Githubissues

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS

https://www.silverstripe.org

BSD 3-Clause "New" or "Revised" License

720 stars 820 forks source link

Add support for polymorphic has_one to eager loading #11203

Closed beerbohmdo closed 1 month ago

beerbohmdo commented 2 months ago

Description

Polymorphic has_one relations are currently not supported by eager-loading it just throws an error that DataObject is not a valid data class.

Additional context or points of discussion

No response

Validations

[X] You intend to implement the feature yourself
[X] You have read the contributing guide
[X] You strongly believe this feature should be in core, rather than being its own community module
[X] You have checked for existing issues or pull requests related to this feature (and didn't find any)

PRs

11204

GuySartorelli commented 1 month ago

PR merged. This will be automatically tagged by GitHub actions