TreeDropdownField -> DisableFunction not working

icecaster commented 2 months ago

Module version(s) affected

5

Description

TreeDropdownField & its subclasses (TreeMultiselectField)->DisableFunction not working

How to reproduce

This code should produce a dropdown field of all groups, none should be selectable:

$fields->addFieldToTab(
    "Root.Main",
    TreeMultiselectField::create("Test", "Test")
    ->setDisableFunction(function ($node) {
        return true;
    }
));

Possible Solution

No response

Additional Context

No response

Validations

[X] Check that there isn't already an issue that reports the same bug
[X] Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

GuySartorelli commented 1 month ago

~This was fixed as part of https://github.com/bringyourownideas/silverstripe-maintenance/pull/220 - because of the breadth of the changes it won't be tagged until the next minor release.~

GuySartorelli commented 1 month ago

Oops, wrong issue

maxime-rainville commented 1 month ago

Looks like this is a frontend problem. The nodes are marked as disabled in the JSON request.

Just seems like the front end doesn't care. Arguably, we should probably have a check to make sure that you get block server side if you pick a disabled option.

silverstripe / silverstripe-framework